Skip to content

Model Inference Dependencies - Dynamic imports #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

aditya0by0
Copy link
Member

@aditya0by0 aditya0by0 requested a review from sfluegel05 July 30, 2025 16:30
@aditya0by0 aditya0by0 self-assigned this Jul 30, 2025
@aditya0by0 aditya0by0 added enhancement New feature or request priority: high labels Jul 30, 2025
@aditya0by0 aditya0by0 marked this pull request as ready for review August 9, 2025 22:02
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the extras-system correctly, given the dependencies

dependencies = ["A"]
[project.optional-dependencies]
opt1 = ["B"]
opt2 = ["C"]

you will get the following install options:

pip install my_package -> installs A
pip install my_package[opt1] -> installs A and B
pip install my_package[all] -> installs A, B and C

Given this structure, I would set the dependencies you put under inference as dependencies and make the rest optional (please correct me if I got this wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants