Skip to content

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Aug 19, 2025

Hello! I was just trying to run chebifier myself and thought there were a few ways it could be improved for quality of life.

This PR does the following:

  1. Updates the constructor of BaseEnsemble
    • Make it possible to not have to pass a configuration. In this case, load the default configuration. Users highly appreciate there being a good default.
    • Make it possible to pass a file path, reducing verbosity of the example
  2. Expose the BaseEnsemble from the top-level so it's easier to import
  3. Simplify the example in the README by using the built-in configuration

cthoyt and others added 4 commits August 19, 2025 11:19
This PR updates the BaseEnsemble constructor to allow the following:

1. Passing a string or path to the configuration
2. Not passing a configuration at all, which will automatically load the default configuration. This is now the default, since most users won't want to have to configure it (it should have reasonable defaults)
@sfluegel05
Copy link
Contributor

Hi! Thanks for your contribution. I think being able to use the BaseEnsemble class (or any ensemble class) without parameters would indeed improve usability.

I had some trouble running the code, in particular

  1. Exposing BaseEnsemble to the top level lead to a circular import error:
    ImportError: cannot import name 'modelwise_smiles_lru_cache' from partially initialized module 'chebifier' (most likely due to a circular import) (python-chebifier\chebifier\__init__.py)
    I haven't pinned down exactly where this comes from and removed the __all__ statement for now.

  2. The BaseEnsemble init can load the config, but there is some post-processing attached that so far only happened in the CLI. I have moved the post-processing to the utils and called it from the BaseEnsemble.

@cthoyt Could you check if this is what you had in mind?

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 16, 2025

@sfluegel05 thanks for taking a look! i'll try and resolve this ASAP and ping you here after

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 16, 2025

@sfluegel05 just resolved the circular imports

@sfluegel05
Copy link
Contributor

thanks for fixing this!

@sfluegel05 sfluegel05 merged commit 7aaf46f into ChEB-AI:dev Sep 16, 2025
1 check passed
@cthoyt cthoyt deleted the simplify-getting-started branch September 16, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants