Skip to content

chore: improve shuffling perf #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: improve shuffling perf #518

wants to merge 1 commit into from

Conversation

wemeetagain
Copy link
Member

Our old shuffle implementation was worse than it needed to be for several reasons:

  • we often only want to randomly sample k of n items, where k << n
  • there's a superfluous anonymous function for the randomness

Both are fixed here.

  • only sample k of n items
  • simplify randomness calculation

@wemeetagain wemeetagain requested a review from a team as a code owner March 27, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wemeetagain