fix(deps-dev): Dynamic import node:events #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
reviewed
Jun 3, 2025
tysonclugg
force-pushed
the
fix/import_node_events
branch
from
21a99e1 to
670784e
Compare
Avoids the following error when running `pnpm run test`:
```
test browser
ℹ Browser "chromium" setup complete.
✘ [ERROR] Could not resolve "events"
dist/test/utils/create-pubsub.js:1:32:
1 │ import { setMaxListeners } from 'events';
│ ~~~~~~~~
╵ "./events"
The package "events" wasn't found on the file system but is built into node. Are you trying to
bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```
tysonclugg
force-pushed
the
fix/import_node_events
branch
from
670784e to
7b5a4d2
Compare
|
@achingbrain Now importing from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the following error when running
pnpm run test:Also allows errors not related to failed imports to propagate correctly.