Using lucide icons for starters #2563
Open
+10
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperpolaxinter
requested review from
hayescode,
asvishnyakov and
sandangel
as code owners
dosubot
bot
added
size:S
asvishnyakov
requested changes
Oct 1, 2025
|
@jasperpolaxinter Tests are failing rightfully. We need to support both URLs and icon names; otherwise, this is a breaking change and cannot be merged. |
|
There are actually 3 different cases here:
Maybe it's worthwhile to think about what we'd like. Do we want to support all of these use cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starters currently require a locally stored icon file. Instead, allow the icon field to accept a Lucide icon name string (similar to how commands work). This would simplify starter setup and improve the overall user experience.