fix: propagate IME composition events in AutoResizeTextarea #2575
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoResizeTextarea was not propagating onCompositionStart and onCompositionEnd events to its parent component, causing the parent's isComposing state to remain false during IME input (Japanese, Chinese, Korean, etc.). This resulted in Enter key presses during text conversion being incorrectly interpreted as message send commands. This fix adds proper event propagation by: - Adding onCompositionStart and onCompositionEnd to component props - Creating handler functions that update internal state and call parent handlers - Ensuring both local and parent components track IME composition state correctly Fixes the issue where Japanese input would send messages on Enter during conversion.
servak
requested review from
hayescode,
asvishnyakov and
sandangel
as code owners
dosubot
bot
added
size:M
|
I tested the fix locally, and here is a short demo video. output.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where Japanese (and other IME-based) input would incorrectly send messages when pressing Enter during text conversion.
Problem
After PR #2393 rewrote the chat input to use
<textarea>, theAutoResizeTextareacomponent was not propagatingonCompositionStartandonCompositionEndevents to its parent component (Input.tsx). This caused the parent'sisComposingstate to always remainfalse, resulting in Enter key presses during IME text conversion being incorrectly interpreted as message send commands.Solution
onCompositionStartandonCompositionEndtoAutoResizeTextareacomponent propsisComposingstateAutoResizeTextareaand parent components correctly track IME composition stateTest Plan
Tested with Japanese IME input:
Related Issues
This bug was introduced in PR #2393 when migrating from
contentEditableto<textarea>.