Multiple stake improvements #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scammi
commented
Jul 14, 2023
scammi
commented
- Using ERC20 interface with decimals.
- Base multiplier per staking token.
robsecord
requested changes
Jul 24, 2023
| IERC20 token = ERC20(_programData.rewardToken); | ||
| token.safeTransferFrom(msg.sender, address(this), amount); | ||
| IERC20Detailed token = IERC20Detailed(_programData.rewardToken); | ||
| token.transferFrom(msg.sender, address(this), amount); |
There was a problem hiding this comment.
this should be "safeTransferFrom"
There was a problem hiding this comment.
safeTransferFrom is not in the base ERC20 standard.
The token needs to implement the safe token library, and the IONX token does not implement it.
| assetStake.claimableRewards = 0; | ||
| // Transfer Available Rewards to Receiver | ||
| ERC20(_programData.rewardToken).safeTransfer(receiver, totalReward); | ||
| IERC20Detailed(_programData.rewardToken).transfer(receiver, totalReward); |
There was a problem hiding this comment.
this should be "safeTransfer"
|
TODO: Implement ERC721 Receiver contract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.