Skip to content

Conversation

CharlieTLe
Copy link
Owner

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

CharlieTLe and others added 30 commits July 23, 2025 14:20
Define governance model for sub-projects.

Signed-off-by: Charlie Le <[email protected]>
Fixes: cortexproject#6684

Signed-off-by: Charlie Le <[email protected]>
…s-typos

docs: fix typos in configuration/arguments.md
### Main fixes applied:

1. **Line 5**: Fixed "long term storage" → "long-term storage" (consistency with hyphenation)

2. **Line 12**: Fixed "Long term storage" → "Long-term storage" (consistency with hyphenation)

3. **Line 126**: Fixed "the AMP" → "AMP" (removed unnecessary article - "the" before abbreviation when referring to the service directly)

4. **Line 126**: Fixed "managed monitoring for your containers" → "managed monitoring service for your containers" (added missing word "service" for clarity)

### Minor grammar improvements:

- **Hyphenation consistency**: Made sure "long-term" is consistently hyphenated throughout
- **Article usage**: Corrected the use of "the" before abbreviations where it wasn't needed
- **Completeness**: Added missing words to make sentences grammatically complete

The document now has consistent terminology, proper grammar, and professional language throughout. All the technical content, links, and formatting remain intact while the language is now more polished and consistent.

Signed-off-by: Charlie Le <[email protected]>
* first draft parquet guide

Signed-off-by: alanprot <[email protected]>

* Removing some not needed sections

Signed-off-by: alanprot <[email protected]>

* adding why

Signed-off-by: alanprot <[email protected]>

* adding why

Signed-off-by: alanprot <[email protected]>

* addressing comments

Signed-off-by: alanprot <[email protected]>

* Adding cache section

Signed-off-by: alanprot <[email protected]>

* run make clean-white-noise

Signed-off-by: alanprot <[email protected]>

* removing one tip that does not make much sense

Signed-off-by: alanprot <[email protected]>

---------

Signed-off-by: alanprot <[email protected]>
…oject#6920)

* add configuration to disallow parquet fallback to store gateway

Signed-off-by: yeya24 <[email protected]>

* make parquet consistency check error as a function

Signed-off-by: yeya24 <[email protected]>

* changelog

Signed-off-by: yeya24 <[email protected]>

* disable parquet fallback

Signed-off-by: yeya24 <[email protected]>

---------

Signed-off-by: yeya24 <[email protected]>
* Exposing parquet configs

Signed-off-by: alanprot <[email protected]>

* rebase + document the parquet_queryable_fallback_disabled option

Signed-off-by: alanprot <[email protected]>

* some small improvements on the parqute guide

Signed-off-by: alanprot <[email protected]>

---------

Signed-off-by: alanprot <[email protected]>
* add zstd and snappy compression for query api

Signed-off-by: Ahmed Hassan <[email protected]>

* parse X-Uncompressed-Length only if header exists

Signed-off-by: Ahmed Hassan <[email protected]>

* fix formatting

Signed-off-by: Ahmed Hassan <[email protected]>

* refactor query decompression

Signed-off-by: Ahmed Hassan <[email protected]>

* ensure zstd reader is closed after decompression

Signed-off-by: Ahmed Hassan <[email protected]>

* add tests for zstd and snappy compression

Signed-off-by: Ahmed Hassan <[email protected]>

* update changelog

Signed-off-by: Ahmed Hassan <[email protected]>

* update docs

Signed-off-by: Ahmed Hassan <[email protected]>

* apply query response size limit after decompression if header is missing

Signed-off-by: Ahmed Hassan <[email protected]>

* fix formatting

Signed-off-by: Ahmed Hassan <[email protected]>

---------

Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
* Expose DetailedMetricsEnabled for all ring configs

Signed-off-by: Daniel Deluiggi <[email protected]>

* changelog

Signed-off-by: Daniel Deluiggi <[email protected]>

---------

Signed-off-by: Daniel Deluiggi <[email protected]>
…s services (cortexproject#6895)

* add request ID injection to context to enable tracking reqeusts across downstream services

Signed-off-by: Erlan Zholdubai uulu <[email protected]>

* copy logging headers map to avoid concurrent write access for backwards compatibility case

Signed-off-by: Erlan Zholdubai uulu <[email protected]>

---------

Signed-off-by: Erlan Zholdubai uulu <[email protected]>
…oject#6898)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixing typo

Signed-off-by: Charlie Le <[email protected]>
k logs cortex-parquet-converter-0
error loading config from /etc/cortex/cortex.yaml: Error parsing config file: yaml: unmarshal errors:
  line 59: cannot unmarshal !!str `100MB` into int
  line 60: cannot unmarshal !!str `1GB` into int

Signed-off-by: Charlie Le <[email protected]>
…project#6937)

* update parquet common and expose parquet labels cache config

Signed-off-by: yeya24 <[email protected]>

* update docs

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: yeya24 <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
erlan-z and others added 26 commits September 2, 2025 10:35
* remove limiting query rejection to only adhoc queries for ingester. This shouldn't have been included as discussed in PR cortexproject#6947

Signed-off-by: Erlan Zholdubai uulu <[email protected]>

* bug fixes for query rejection. fix metric and remove unused enabled flag.

Signed-off-by: Erlan Zholdubai uulu <[email protected]>

---------

Signed-off-by: Erlan Zholdubai uulu <[email protected]>
…cortexproject#6979)

* Override exporter: expose all fields that can be converted to float64

Signed-off-by: SungJin1212 <[email protected]>

* fix test

Signed-off-by: SungJin1212 <[email protected]>

* fix changelog

Signed-off-by: SungJin1212 <[email protected]>

---------

Signed-off-by: SungJin1212 <[email protected]>
* Make error from RBT query rejection retryable in querier

Signed-off-by: Justin Jung <[email protected]>

* Add tests

Signed-off-by: Justin Jung <[email protected]>

* Lint

Signed-off-by: Justin Jung <[email protected]>

* Lint import

Signed-off-by: Justin Jung <[email protected]>

* Added test in error translate queryable

Signed-off-by: Justin Jung <[email protected]>

---------

Signed-off-by: Justin Jung <[email protected]>
* modernize the entire codebase

Signed-off-by: SungJin1212 <[email protected]>

* add CI to modernize check

Signed-off-by: SungJin1212 <[email protected]>

* fix modernize

Signed-off-by: SungJin1212 <[email protected]>

* Delete unnecessary b.ResetTimer()

Signed-off-by: SungJin1212 <[email protected]>

* Remove StringsContain

Signed-off-by: SungJin1212 <[email protected]>

* delete unnecessary map copy in ingester test

Signed-off-by: SungJin1212 <[email protected]>

---------

Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: Friedrich Gonzalez <[email protected]>
Co-authored-by: Friedrich Gonzalez <[email protected]>
…user series error message (cortexproject#7015)

* Make the per labelset series limit error message consistent with per user series error message

Signed-off-by: Alvin Lin <[email protected]>

* address PR comments

Signed-off-by: Alvin Lin <[email protected]>

---------

Signed-off-by: Alvin Lin <[email protected]>
* Use aws-sdk-go-v2 in dynamodb

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Fix imports

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Fix setting region

Signed-off-by: Friedrich Gonzalez <[email protected]>

---------

Signed-off-by: Friedrich Gonzalez <[email protected]>
* Add Swiggy to Adopters list

Signed-off-by: vivekgarg20 <[email protected]>
…#7025)

* fix remote read snappy input regression due to empty request body

Signed-off-by: yeya24 <[email protected]>

* changelog

Signed-off-by: yeya24 <[email protected]>

---------

Signed-off-by: yeya24 <[email protected]>
* Updates armon/hashicorp metrics library

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Updates go mod vendor

Signed-off-by: Friedrich Gonzalez <[email protected]>

---------

Signed-off-by: Friedrich Gonzalez <[email protected]>
…#6996)

* Add metric for number of series with discarded samples

Signed-off-by: Essam Eldaly <[email protected]>

* Add cleanup for metric

Signed-off-by: Essam Eldaly <[email protected]>

* Update changelog

Signed-off-by: Essam Eldaly <[email protected]>

* Rename metric to include per labelset

Signed-off-by: Essam Eldaly <[email protected]>

* Rename variables and help text

Signed-off-by: Essam Eldaly <[email protected]>

* Test fix

Signed-off-by: Essam Eldaly <[email protected]>

* Seperate and fix per labelset tracker

Signed-off-by: Essam Eldaly <[email protected]>

* Add per labelset tests

Signed-off-by: Essam Eldaly <[email protected]>

* Update changelog and remove unneeded async calls

Signed-off-by: Essam Eldaly <[email protected]>

---------

Signed-off-by: Essam Eldaly <[email protected]>
* fix AllUserStats during rolling updates on ingester

Signed-off-by: SungJin1212 <[email protected]>

* Add dedicated column to expose # Queried Ingesters

Signed-off-by: SungJin1212 <[email protected]>

* fix test

Signed-off-by: SungJin1212 <[email protected]>

---------

Signed-off-by: SungJin1212 <[email protected]>
…g Parquet file generation (cortexproject#7003)

* feat(parquetconverter): add support for additional sort columns during Parquet file generation

Signed-off-by: Angith <[email protected]>

* docs: update CHANGELOG.md to include support for sort columns during Parquet file generation

Signed-off-by: Angith <[email protected]>

* fix: Remove duplicate flag registration for parquet-converter.sort-columns

Signed-off-by: Angith <[email protected]>

* fix: exluded sort columns from base converter options

Signed-off-by: Angith <[email protected]>

* doc: updated config-file-reference.md with parquet_converter_sort_columns configuration

Signed-off-by: Angith <[email protected]>

* doc: cleaned up white noise

Signed-off-by: Angith <[email protected]>

---------

Signed-off-by: Angith <[email protected]>
Signed-off-by: Charlie Le <[email protected]>
Signed-off-by: Charlie Le <[email protected]>
@CharlieTLe CharlieTLe force-pushed the cortex-config-json-schema branch from 647fe9f to 011d192 Compare September 27, 2025 19:46
@CharlieTLe CharlieTLe closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: "replication_set_should_not_change_if_ring_did_not_change,_when_num_of_instance_per_zone_is_inconsistent"