Skip to content

Fix bugs checked in SpotBugs #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fix bugs checked in SpotBugs #64

wants to merge 16 commits into from

Conversation

@JellyBrick
Copy link

@JellyBrick JellyBrick commented Apr 11, 2022 •
edited
Loading

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issues with the library's codebase.

Description

  • Set sourceCompatibility (and targetCompatibility) to Java 1.8
  • Remove unnecessary LinkedList (changed to ArrayList)
    • LinkedList.get: O(n), ArrayList.get: O(1)
  • Fix impossible downcast like this.userPermissions = (Permission[]) userPermissions.toArray();
  • Set inner classes to 'static'
  • SessionData: override hashCode() (https://stackoverflow.com/questions/2265503)

@Chew Chew added module: command Commands module module: commons Commons module module: examples Examples module module: menu Menu module module: oauth2 Oauth2 module labels Apr 20, 2022
@JellyBrick
Copy link
Author

@Chew Could you review this pull request?

@JellyBrick JellyBrick changed the title apply the fix (SpotBugs) apply fix from SpotBugs Aug 22, 2022
@JellyBrick JellyBrick changed the title apply fix from SpotBugs Fix bugs checked in SpotBugs Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Andre601 Andre601 Andre601 left review comments

@alvin0319 alvin0319 alvin0319 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

module: command Commands module module: commons Commons module module: examples Examples module module: menu Menu module module: oauth2 Oauth2 module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JellyBrick @Andre601 @alvin0319 @Chew