fix two possible buffer overflow bugs#296
Open
Frank-Buss wants to merge 1 commit intoChia-Network:mainfrom
Open
fix two possible buffer overflow bugs#296Frank-Buss wants to merge 1 commit intoChia-Network:mainfrom
Frank-Buss wants to merge 1 commit intoChia-Network:mainfrom
Conversation
Author
|
PS: technically the test for <= 0 is a semantic change, but disc size can't be 0 because the discriminant is a prime used to define the class group, which can't be represented with zero bytes. Additionally, atoi returns 0 for non-numeric input, so this catches malformed sizes. And the binary quadratic form also requires actual coefficients, so can't be 0 either. Finally, form_size is a signed char, so <= 0 catches wire values 128-255 that wrap negative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds strict input-size validation during session initialization to prevent buffer overflows.
InitSession, validatedisc_int_sizeagainstsizeof(disc)and throw on invalid valuesform_sizeagainstsizeof(initial_form_s)and throw on invalid valuesWritten by Cursor Bugbot for commit 216bb7a. This will update automatically on new commits. Configure here.