Skip to content

Conversation

@glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 2, 2024

Summary of the changes (Less than 80 chars)

  • Omitted requireOneSlicingArgument if not set in listSize directive.

Closes #7398


@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (e3c132c) to head (94a3c41).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7418   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files        2674     2674           
  Lines      140657   140661    +4     
  Branches    16358    16358           
=======================================
+ Hits       104282   104286    +4     
- Misses      30780    30783    +3     
+ Partials     5595     5592    -3     
Flag Coverage Δ
unittests 74.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@glen-84 glen-84 marked this pull request as draft September 4, 2024 08:32
@michaelstaib michaelstaib self-assigned this Sep 24, 2024
@michaelstaib michaelstaib self-requested a review September 24, 2024 09:56
@michaelstaib michaelstaib marked this pull request as ready for review September 29, 2024 20:41
@glen-84 glen-84 added this to the HC-15.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Omit requireOneSlicingArgument from @listSize if false

3 participants