Cleanup winget upgrade - #4410
Conversation
| $msg = "[Invoke-WPFInstallUpgrade] Install process is currently running. Please check for a powershell window labeled 'Winget Install'" | ||
| [System.Windows.MessageBox]::Show($msg, "Winutil", [System.Windows.MessageBoxButton]::OK, [System.Windows.MessageBoxImage]::Warning) | ||
| return | ||
| } |
There was a problem hiding this comment.
no reason to check if winget install process is running because you can't click upgrade when installing apps since there is the "installing apps" pop out
ChrisTitusTech
left a comment
ChrisTitusTech
left a comment
There was a problem hiding this comment.
Locks up the UI and normal users won't know to look in the terminal.
it now uses run spaces so this shouldn't be a issue anymore |
notyusufkhalifa
left a comment
notyusufkhalifa
left a comment
There was a problem hiding this comment.
@GabiNun2, Looks good.
thanks |
The reason for this is if you have a bunch of apps installed through winget it will take time to update them all. Unlinking it from the GUI allows users to close WinUtil and let the update run in the background. Moving it into the main process you would want some checks to ensure the user is aware updates are happening and if they close the GUI that those updates will stop. |
fixed it will now launch another ps window |
3 participants
Type of Change
Description
The
Invoke-WPFInstallUpgradefunction was the only function that used theGet-WinUtilInstallerProcessfunction andGet-WinUtilInstallerProcess.ps1function at all so i decided to remove them and makeInvoke-WPFInstallUpgradestandaloneI also made sure the upgrade process opens inside of the winutil window there was no reason for it to open another powershell window
I also made sure it check if winget is installed before upgrading all applications
Issue related to PR