attempt to make changes to use the emote effects from the updated emotes package - #1
Open
jamesmanning wants to merge 17 commits into
Open
attempt to make changes to use the emote effects from the updated emotes package#1jamesmanning wants to merge 17 commits into
jamesmanning wants to merge 17 commits into
Conversation
- sass-loader had to bump up to 1.0 - pre-1.0 versions would fail with "ERROR in `libsass` bindings not found. Try reinstalling `node-sass`?" - the upgrade of sass-loader to 1.0 required node-sass upgrading to v3
- invert and hue-rotate needed the appropriate berrymotes invert js (snippet copied from berrymotes.berrytube.js - all the animation effects (brody, vibrate, zspin, etc) needed inclusion of http://berrymotes.com/assets/berrymotes.core.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't get libsass / node-sass working on my local Windows machine at the moment, so haven't been able to verify whether the changes work or not.
Had to add a few new functions in the emotes package (see https://github.com/jamesmanning/emotes/commits if needed) so might need to npm update to get an updated version of it.
with this change, the emote effects (vibrate, reverse, etc) should all work, and with the switch to EmoteParser's regex (now exposed) it should support the emotes that includes lines of text ('advice' emotes, 'sign' emotes, etc)