[ignore] Fix Ansible Galaxy check failing on ignore warning files. (DCNE-502) #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiib
force-pushed
the
ansible-galaxy-log-check
branch
from
7e9a039 to
c5e84da
Compare
samiib
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
shrsr
as code owners
samiib
changed the title
|
This should help progress the CI in #143 |
shrsr
requested changes
Aug 4, 2025
.github/workflows/ansible-test.yml
Outdated
| print(line) | ||
| if 'Ignore files skip ansible-test sanity tests, found ignore' not in line: | ||
| err_count += 1 | ||
| exit(err_count) |
There was a problem hiding this comment.
Is there a chance where we could encounter err_count to be 256?
There was a problem hiding this comment.
Yes, potentially. I will change it to exit with 1 instead. We only need a non 0 exit code for the step to fail.
|
@samiib Thanks for working on this! LGTM |
lhercot
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle ignore file warnings so it won't fail the CI.
Tested run: https://github.com/CiscoDevNet/ansible-nd/actions/runs/16722131242/job/47328767670?pr=164#step:10:20