Addition of nd_multi_cluster_connectivity module and its test file (DCNE-458) #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
shrsr
changed the title
anvitha-jain
requested changes
Aug 12, 2025
| inband_epg: ansible-inband | ||
| state: present | ||
|
|
||
| - name: Query ND cluster |
There was a problem hiding this comment.
Add query example for ACI cluster as well.
shrsr
commented
Aug 12, 2025
| state: query | ||
| register: query_result | ||
|
|
||
| - name: Query all the clusters |
There was a problem hiding this comment.
Implement separate query all for ND clusters and aci clusters in the info module
sajagana
requested changes
Aug 13, 2025
sajagana
added a commit
to sajagana/ansible-nd
that referenced
this pull request
Aug 18, 2025
…e and copied module utils nd.py file changes from CiscoDevNet#166 PR
… query for aci cluster
anvitha-jain
requested changes
Aug 18, 2025
| """ | ||
|
|
||
| EXAMPLES = r""" | ||
| - name: Create ND cluster |
samiib
requested changes
Aug 19, 2025
plugins/module_utils/nd.py
Outdated
| @@ -516,6 +523,7 @@ def get_diff(self, unwanted=None): | |||
| del existing[key] | |||
| except KeyError: | |||
| pass | |||
| if key in sent: | |||
| try: | |||
| del sent[key] | |||
| except KeyError: | |||
There was a problem hiding this comment.
Do we still need this try/except on KeyError after adding the key check above?
| description: | ||
| - The out-of-band management configuration for the cluster. | ||
| type: str | ||
| orchestration: |
There was a problem hiding this comment.
Do you need this option? It appears orchestration in the features list is used instead.
There was a problem hiding this comment.
Not required anymore!
| license_tier=dict(type="str", choices=["advantage", "essentials", "premier"]), | ||
| features=dict(type="list", elements="str", choices=["telemetry", "orchestration"]), | ||
| inband_epg=dict(type="str"), | ||
| outband=dict(type="str"), |
There was a problem hiding this comment.
Is this option used anywhere?
| choices: [ telemetry, orchestration ] | ||
| inband_epg: | ||
| description: | ||
| - The in-band EPG (Endpoint Group) for the cluster. |
There was a problem hiding this comment.
Suggested change
| - The in-band EPG (Endpoint Group) for the cluster. | |
| - The in-band EPG (Endpoint Group) for the cluster. | |
| - This option is only used when C(telemetry) is enabled in O(features). |
gmicol
requested changes
Aug 19, 2025
| license_tier=dict(type="str", choices=["advantage", "essentials", "premier"]), | ||
| features=dict(type="list", elements="str", choices=["telemetry", "orchestration"]), | ||
| inband_epg=dict(type="str"), | ||
| orchestration=dict(type="bool"), |
There was a problem hiding this comment.
Orchestration attribute probably needs to be removed from argument_spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.