Add a new network resource module nd_local_user for local users on Nexus Dashboard v4.1.0 or higher (DCNE-543) #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
requested review from
akinross,
anvitha-jain,
lhercot,
sajagana and
samiib
as code owners
github-actions
bot
changed the title
gmicol
force-pushed
the
add_network_ressource_nd_local_user
branch
from
a4b3de7 to
6a9aefd
Compare
akinross
reviewed
Sep 4, 2025
plugins/modules/nd_local_user.py
Outdated
Comment on lines
218
to
221
| identifier_key = "loginID" | ||
|
|
||
| nd = NDNetworkResourceModule(module, path, identifier_key) |
There was a problem hiding this comment.
what if an object is identified by multiple keys?
| sent = deepcopy(new_config) | ||
|
|
||
| for key in unwanted: | ||
| if isinstance(key, str): |
There was a problem hiding this comment.
what is the reason for allowing unwanted list and str input?
| # TODO: Add description to functions and clean the code | ||
| # TODO: Add exception cases | ||
| # NOTE: ONLY works for new API endpoints introduced in ND v4.1.0 and later | ||
| class NDNetworkResourceModule(NDModule): |
There was a problem hiding this comment.
I like the approach of the class with generic methods that handle actions like merge etc
| from ansible_collections.cisco.nd.plugins.module_utils.nd import NDModule, issubset, sanitize | ||
|
|
||
|
|
||
| # TODO: Maybe make it an all new module class with request, exit_json, fail_json, etc... |
There was a problem hiding this comment.
agree with this part, where we can also have a look at clean up current code
| self.previous = [] | ||
| self.proposed = [] | ||
| self.sent = [] | ||
| self.init_all_existing = self.query_obj(path=path, ignore_not_found_error=True) |
There was a problem hiding this comment.
will this work for all endpoints? I noticed from NDO point of view for instance that the detailed view sometimes is deviating from the list view. Example would we templates and template summaries.
gmicol
force-pushed
the
add_network_ressource_nd_local_user
branch
3 times, most recently
from
e38fee8 to
df74fbf
Compare
… Nexus Dashboard v4.1.0 and higher.
gmicol
force-pushed
the
add_network_ressource_nd_local_user
branch
from
df74fbf to
fe89c61
Compare
anvitha-jain
reviewed
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.