XR Clean InstallImagesAndPackages improvement#90
Open
Tristou27 wants to merge 2 commits intoCiscoTestAutomation:mainfrom
Open
XR Clean InstallImagesAndPackages improvement#90Tristou27 wants to merge 2 commits intoCiscoTestAutomation:mainfrom
Tristou27 wants to merge 2 commits intoCiscoTestAutomation:mainfrom
Conversation
Contributor
|
@Tristou27 can you attach logs for this change? |
bobody64
reviewed
Jan 11, 2022
Contributor
bobody64
left a comment
bobody64
left a comment
There was a problem hiding this comment.
Please also create a changelog
Tristou27
changed the title
Author
|
Changelog file have been added, sorry for the delay. |
lsheikal
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This small change in the XR Clean InstallImagesAndPackages should ease the error detection for steps "install add" and "install activate".
In recent software, these modes are launched by default with 'synchronous' keyword that block the user session during the install operation (no prompt). Errors were detected via the device.execute(error_pattern=...) syntax.
However, with older softwares (XR < 7) these install ops are launched in the background and the initial code was expecting only success answers with the device.expect() syntax. When "install add/activate" failed in the background, the error message was not catched by the stage and the script waited the timeout.
With this change, we should be able to handle both cases. I tried to keep it coherent with the previous code in the previous steps. Also, I prefered to make the entire stage fail (by failing a step) when install add/activate fail instead of continuing for nothing.