This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Only add a comment if one does not already exist#37
Open
edhgoose wants to merge 3 commits intoClearTax:masterfrom
Open
Only add a comment if one does not already exist#37edhgoose wants to merge 3 commits intoClearTax:masterfrom
edhgoose wants to merge 3 commits intoClearTax:masterfrom
Conversation
edhgoose
force-pushed
the
feature-only-add-no-id-comment-once
branch
from
f3ee4a9 to
9933079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
We have a few cases where having no id is sort of ok (temporary branches, hacking around, sharing an idea quickly), and at the moment every time we push to that branch, we get a new comment.
This stops the comment from being added if it already exists.
Thanks!
(We did the same with Pivotal Lint over here too: ClearTax/pivotal-lint#28, which we're no longer using)