Skip to content

Capturing uncaught sign_request error and returning on callback #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Capturing uncaught sign_request error and returning on callback #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/saml2.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,9 @@ module.exports.ServiceProvider =
return cb ex
delete uri.search # If you provide search and query search overrides query :/
if options.sign_get_request
_.extend(uri.query, sign_request(deflated.toString('base64'), @private_key, options.relay_state))
# adding this try/catch to stop async uncaught errors from passing through
try _.extend(uri.query, sign_request(deflated.toString('base64'), @private_key, options.relay_state))
catch error then return cb(error)
else
uri.query.SAMLRequest = deflated.toString 'base64'
uri.query.RelayState = options.relay_state if options.relay_state?
Expand Down