-
Notifications
You must be signed in to change notification settings - Fork 351
Add REST catalog support in docs (#1) #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@somratdutta is attempting to deploy a commit to the ClickHouse Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
@somratdutta would you mind to merge main into your branch? The error the vercel deployment is failing on is unrelated to your changes and was fixed yesterday. |
Sure @Blargian. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@somratdutta firstly, thank you so much for this contribution, I am really excited to see it! I've left a few comments. I was unable to get this working following these steps. Let's put together an example which can be easily reproduced.
clickhouse: | ||
image: clickhouse/clickhouse-server:main | ||
container_name: clickhouse | ||
user: '0:0' # Ensures root permissions | ||
networks: | ||
iceberg_net: | ||
ports: | ||
- "8123:8123" | ||
- "9002:9000" | ||
volumes: | ||
- ./clickhouse:/var/lib/clickhouse | ||
- ./clickhouse/data_import:/var/lib/clickhouse/data_import # Mount dataset folder | ||
networks: | ||
- iceberg_net | ||
environment: | ||
- CLICKHOUSE_DB=default | ||
- CLICKHOUSE_USER=default | ||
- CLICKHOUSE_DO_NOT_CHOWN=1 | ||
- CLICKHOUSE_PASSWORD= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clickhouse: | |
image: clickhouse/clickhouse-server:main | |
container_name: clickhouse | |
user: '0:0' # Ensures root permissions | |
networks: | |
iceberg_net: | |
ports: | |
- "8123:8123" | |
- "9002:9000" | |
volumes: | |
- ./clickhouse:/var/lib/clickhouse | |
- ./clickhouse/data_import:/var/lib/clickhouse/data_import # Mount dataset folder | |
networks: | |
- iceberg_net | |
environment: | |
- CLICKHOUSE_DB=default | |
- CLICKHOUSE_USER=default | |
- CLICKHOUSE_DO_NOT_CHOWN=1 | |
- CLICKHOUSE_PASSWORD= | |
clickhouse: | |
image: clickhouse/clickhouse-server:25.5.6 | |
container_name: clickhouse | |
user: '0:0' # Ensures root permissions | |
networks: | |
iceberg_net: | |
ports: | |
- "8123:8123" | |
- "9002:9000" | |
volumes: | |
- ./clickhouse:/var/lib/clickhouse | |
- ./clickhouse/data_import:/var/lib/clickhouse/data_import # Mount dataset folder | |
networks: | |
- iceberg_net | |
environment: | |
- CLICKHOUSE_DB=default | |
- CLICKHOUSE_USER=default | |
- CLICKHOUSE_DO_NOT_CHOWN=1 | |
- CLICKHOUSE_PASSWORD= |
┌─name──────────┐ | ||
│ default.taxis │ | ||
└───────────────┘ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I unfortunately don't get this when I try to run the steps. I'm getting back:
SHOW TABLES IN demo
Query id: 4411372a-a71c-44e9-b27b-146af2048670
Ok.
0 rows in set. Elapsed: 0.047 sec.
demo
is however created:
SHOW DATABASES
Query id: 70f26176-08cd-4e5e-b788-44ce1adf10eb
┌─name───────────────┐
1. │ INFORMATION_SCHEMA │
2. │ default │
3. │ demo │
4. │ information_schema │
5. │ system │
└────────────────────┘
Can you confirm you were able to get this working locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mentioned the reason below.
Thanks @Blargian for getting back fast on this. Hoping this clears things up. |
- Change allow_experimental_database_rest_catalog to allow_experimental_database_iceberg - This is the correct flag name for enabling Iceberg database integration
- Fix description to remove S3 buckets reference (not relevant for this guide) - Fix docker-compose YAML network configuration to avoid duplication - Add step-by-step setup instructions for better clarity - Add troubleshooting guidance for users who don't see expected tables - Include note about sample data loading requirements Addresses feedback from PR ClickHouse#4031 review comments
- Step 1: Create new folder and docker-compose.yml from Databricks repo - Step 2: Create docker-compose.override.yml with ClickHouse configuration - Step 3: Run docker compose up - Step 4: Wait for services and check logs This addresses Blargian's specific feedback in PR ClickHouse#4031 for clearer setup instructions.
@somratdutta Thanks for clarifying, and sorry for the confusion on my part! Perfect, I'll keep an eye out for when that PR gets merged and we can merge this in shortly after. |
@somratdutta would you mind to merge main into your branch? Should fix the vercel deploy failure |
Trademark License AddendumMerging of this pull request is temporarily blocked as it potentially contains a contribution containing a trademark. git diffPlease Click to see Trademark License AddendumThis Trademark License Addendum ("Addendum") shall, if You have opted
To unblock this PR, reply with exactly:
|
Sure @Blargian ! |
I agree to the Trademark License Addendum |
Trademark license agreement confirmed ✅The trademark license agreement has been confirmed for @somratdutta. Status: Confirmed This PR is now unblocked and can proceed with normal review. |
Summary
This PR adds comprehensive documentation for ClickHouse's REST Catalog integration.
Checklist