Skip to content

Functions: start generating string replacement functions #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

Functions: start generating string replacement functions #4583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c882fc6
Start generating string replacement functions
Blargian Oct 16, 2025
04c513c
Merge branch 'main' into Blargian-patch-399150
Blargian Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/settings/autogenerate-settings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ if [ -f "$FUNCTION_SQL_FILE" ]; then
"Time Series"
"Other"
"Time Window"
"String Replacement"
"Tuple"
)

Expand Down Expand Up @@ -399,6 +400,7 @@ insert_src_files=(
"time_series-functions.md"
"other-functions.md"
"time_window-functions.md"
"string_replacement-functions.md"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent naming between source (string_replacement) and destination (string-replace) plus mismatch between 'replacement' vs 'replace'. This likely breaks the expected index-based mapping or results in a missing destination file. Recommend standardizing to either 'string_replacement-functions.md' / 'string-replacement-functions.md' (matching existing pattern of underscore in source, hyphen in dest while keeping the same stem) or 'string_replace-functions.md' / 'string-replace-functions.md', but keep the stem identical in both arrays.

Suggested change
"string_replacement-functions.md"
"string_replace-functions.md"

Copilot uses AI. Check for mistakes.

"tuple-functions.md"
)

Expand Down Expand Up @@ -429,6 +431,7 @@ insert_dest_files=(
"docs/sql-reference/functions/time-series-functions.md"
"docs/sql-reference/functions/other-functions.md"
"docs/sql-reference/functions/time-window-functions.md"
"docs/sql-reference/functions/string-replace-functions.md"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent naming between source (string_replacement) and destination (string-replace) plus mismatch between 'replacement' vs 'replace'. This likely breaks the expected index-based mapping or results in a missing destination file. Recommend standardizing to either 'string_replacement-functions.md' / 'string-replacement-functions.md' (matching existing pattern of underscore in source, hyphen in dest while keeping the same stem) or 'string_replace-functions.md' / 'string-replace-functions.md', but keep the stem identical in both arrays.

Copilot uses AI. Check for mistakes.

"docs/sql-reference/functions/tuple-functions.md"
)

Expand Down