[jdbc-v2] Fix statement impl #2471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes statement implementation in the JDBC v2 driver by improving state management, result set handling, and SQL processing. It addresses missing implementations and consolidates SQL utilities to ensure proper JDBC compliance.
Key Changes
- Comprehensive statement state management with proper result set lifecycle handling
- Moved SQL utilities from
SqlParserto centralizedSQLUtilsclass for better maintainability - Enhanced JDBC specification compliance with missing method implementations
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| StatementImpl.java | Major refactoring with proper state management, result set tracking, and complete JDBC method implementations |
| PreparedStatementImpl.java | Updated to use ensureOpen() and SQLUtils for consistent state validation |
| WriterStatementImpl.java | Updated to use ensureOpen() for state validation consistency |
| SQLUtils.java | New centralized utility class for SQL string processing and identifier handling |
| SqlParser.java | Removed duplicate utility methods now centralized in SQLUtils |
| DatabaseMetaDataImpl.java | Updated to use SQLUtils for SQL literal escaping |
| ParsedStatement.java | Updated to use SQLUtils for identifier processing |
| ParsedPreparedStatement.java | Updated to use SQLUtils for identifier processing |
| Various test files | Added comprehensive test coverage for new functionality |
| BETA_ROW_BINARY_WRITER("beta.row_binary_for_simple_insert", "false"), | ||
|
|
||
| /** | ||
| * Enables closing result set before |
There was a problem hiding this comment.
The comment is incomplete. It should describe what happens "before" - likely "before executing new statements" or similar.
Suggested change
| * Enables closing result set before | |
| * Enables closing the result set before executing new statements or when the statement is closed. | |
| * This helps to free up resources automatically without requiring explicit result set closure. |
mzitnik
reviewed
Jul 23, 2025
| * @return true if the identifier needs to be quoted, false otherwise | ||
| */ | ||
| private static boolean needsQuoting(String identifier) { | ||
| if (identifier.isEmpty()) { |
There was a problem hiding this comment.
Should we check here if the identifier is null?
There was a problem hiding this comment.
Yes, I've added IllegalArgumentException
|
We get this 56.4% Coverage on New Code (required ≥ 80%) |
|
|
@mzitnik I've fixed the coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2414
Checklist
Delete items not relevant to your PR: