Skip to content

feat: time and time64 column support #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shivanshuraj1333
Copy link

@shivanshuraj1333 shivanshuraj1333 commented Jul 12, 2025

Summary

Adds time and time64 support, related to ClickHouse/ClickHouse#81217

Closes

Checklist

Delete items not relevant to your PR:

Copy link

windsurf-bot bot commented Jul 12, 2025

PR review rate limit exceeded

@mshustov mshustov requested a review from mzitnik July 13, 2025 09:13
@mzitnik
Copy link
Contributor

mzitnik commented Jul 13, 2025

@shivanshuraj1333, thanks for your contribution, but we already have this PR. Please take a look

A few points

  • I would implement a test in the scope of client-v2 and jdbc-v2
  • It looks like you are missing the implementation in the Serializer
  • Your example uses the old client implementation, which we plan to deprecate.

Thanks
-Mark

@shivanshuraj1333
Copy link
Author

I see, I didn't notice that there's an open PR, let me close this one.
Thanks Mark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants