2324 use post query params (draft) #2561
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try implementing sending statement parameters via multipart/form-data to mitigate issues with too long url.
PR is a work in progress.
Tried to implement passing query parameters as
Content-Type: multipart/form-data
, got some ugly mockup (because of a streaming support), that kind of does work, however, it turns out, that when calling it with many parameters from local integration test, it starts failing with a weird server error even sooner, than the originalapplication/x-www-form-urlencoded
variant:com.clickhouse.client.api.ServerException: Code: 1000. DB::Exception: <Unreadable error message> (transport error: 500)
So, seems, for now it is unfeasible to pursue this.
Closes
Checklist
Delete items not relevant to your PR: