Added Colume init for string, array , map and tuple #2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
approved these changes
Oct 27, 2025
|
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Comment on lines
+666
to
+670
| public static ClickHouseColumn map(String columnName, boolean nullable, ClickHouseDataType keyColumn, ClickHouseColumn valueColumn) { | ||
| return ClickHouseColumn.of(columnName, ClickHouseDataType.Map, nullable, | ||
| ClickHouseColumn.of(keyColumn), | ||
| valueColumn); | ||
| } |
There was a problem hiding this comment.
The keyColumn parameter should be of type ClickHouseColumn instead of ClickHouseDataType to be consistent with the implementation and other similar methods.
Suggested change
| public static ClickHouseColumn map(String columnName, boolean nullable, ClickHouseDataType keyColumn, ClickHouseColumn valueColumn) { | |
| return ClickHouseColumn.of(columnName, ClickHouseDataType.Map, nullable, | |
| ClickHouseColumn.of(keyColumn), | |
| valueColumn); | |
| } | |
| public static ClickHouseColumn map(String columnName, boolean nullable, ClickHouseColumn keyColumn, ClickHouseColumn valueColumn) { | |
| return ClickHouseColumn.of(columnName, ClickHouseDataType.Map, nullable, | |
| keyColumn, | |
| valueColumn); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes
Checklist
Delete items not relevant to your PR: