Renamed NO_THROW_ON_UNKNOWN_CONFIG to IGNORE_UNKNOWN_CONFIG_KEY #2771
Merged
Renamed NO_THROW_ON_UNKNOWN_CONFIG to IGNORE_UNKNOWN_CONFIG_KEY #2771
Conversation
…oid double negative logic
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
mshustov
approved these changes
Mar 3, 2026
mzitnik
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NO_THROW_ON_UNKNOWN_CONFIGtoIGNORE_UNKNOWN_CONFIG_KEYto avoid reversed logicChecklist
Delete items not relevant to your PR:
Note
Medium Risk
Changes the public config key used to ignore unknown properties and alters the check to depend on the property’s boolean value, which may break existing setups relying on the old key or truthy values like
1. Scope is small but affects connection/config parsing behavior.Overview
Renames the opt-out flag for unknown/unmapped configuration from
NO_THROW_ON_UNKNOWN_CONFIGtoIGNORE_UNKNOWN_CONFIG_KEY.Updates
ClientConfigProperties.parseConfigMapso unknown config keys are ignored only whenIGNORE_UNKNOWN_CONFIG_KEYis set to a boolean-true value; otherwise it still throwsClientMisconfigurationException. Integration tests in bothclient-v2andjdbc-v2are updated to use the new key/value.Written by Cursor Bugbot for commit 4310a95. This will update automatically on new commits. Configure here.