Skip to content

Conversation

tpanetti
Copy link
Contributor

@tpanetti tpanetti commented Sep 14, 2025

Overview

This adds support for 3 new table engines in ClickPipe's managed table implementation (ReplacingMergeTree, SummingMergeTree and Null)

Notes

Straightforward change for the most part, validation is properly done on OpenAPI with helpful error messages. Only thing to note is that VersionColumnID is not returned by the API so we maintain the state here.

Also relies on the deployment of https://github.com/ClickHouse/control-plane/pull/19362

@tpanetti tpanetti marked this pull request as ready for review September 15, 2025 04:42
@tpanetti tpanetti requested a review from a team as a code owner September 15, 2025 04:42
Copy link
Collaborator

@whites11 whites11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, but let's please add validation about the fields that required based on the engine type

@tpanetti tpanetti enabled auto-merge (squash) September 18, 2025 22:02
@tpanetti tpanetti merged commit 3caee5c into main Sep 18, 2025
5 checks passed
@tpanetti tpanetti deleted the tp/ClickPipesNewTableEngines branch September 18, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants