Remove concurrency from terraform provider for clickpipes #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved to the advanced settings)
kitop
approved these changes
Oct 7, 2025
jkaflik
reviewed
Oct 8, 2025
There was a problem hiding this comment.
IMO, it makes sense to deprecate it first and then remove it when we release ClickPipes resources in stable builds.
Let's follow a deprecation procedure proposed by Hashicorp:
https://developer.hashicorp.com/terraform/plugin/framework/deprecations#provider-attribute-removal
edit: nvm. this is not used in schema.
jkaflik
approved these changes
Oct 9, 2025
gkorolev
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We are deprecating the usage of Object Storage concurrency scaling from the scaling endpoint in favor of using the advanced settings endpoint for Object Storage.
What
This simply removes the concurrency member from the scaling request struct which was used to include it in the request.