Added CLI option for using gadget locally#132
Open
georgephillips wants to merge 6 commits intomainfrom
Open
Conversation
Co-authored-by: Ross Phillips <12723297+rphillips-cc@users.noreply.github.com>
|
|
||
| function exitOnCancel(value: unknown): void { | ||
| if (isCancel(value)) { | ||
| p.cancel('Operation cancelled.'); |
Contributor
There was a problem hiding this comment.
Suggested change
| p.cancel('Operation cancelled.'); | |
| p.cancel('Operation canceled.'); |
| } | ||
|
|
||
| if (options.version) { | ||
| console.log('gadget 0.0.0'); |
| }); | ||
|
|
||
| if (options?.schemaUrl) { | ||
| return `# yaml-language-server: $schema=${options.schemaUrl}\n${yamlStr}`; |
Contributor
There was a problem hiding this comment.
this should be replaced with version: in the file itself
Contributor
There was a problem hiding this comment.
would prefer to see a lot less as in this file
|
|
||
| /** | ||
| * Converts BuildCommands suggestions into an InitialSiteSettings object, | ||
| * picking the first (best) suggestion from each category. |
Contributor
There was a problem hiding this comment.
this isn't listed in order of preference, but it's a good start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.