Draft
Conversation
This commit creates the foundations of the new CLI, introducing the root command and the `run` command. This latter one will be used to to run the program and will have many sub-commands, which will be added in next commits. Signed-off-by: Elis Lulja <elulja@cisco.com>
asimpleidea
force-pushed
the
cli/run-etcd
branch
from
4d283a7 to
3e97414
Compare
The `run` function executes the program as it used to, but is now oblivious of the service registry you choose. Signed-off-by: Elis Lulja <elulja@cisco.com>
asimpleidea
force-pushed
the
cli/run-etcd
branch
from
346128d to
a3a64de
Compare
This commit moves code to get files from a path or a configmap/secret to separate functions or utility functions.
This commit introduces the `etcd` comand under `run`. It is not active yet as it will be in later commits. Signed-off-by: Elis Lulja <elulja@cisco.com>
This commit uses `run` from the `runWithEtcd` to start the program and register services to etcd. Signed-off-by: Elis Lulja <elulja@cisco.com>
asimpleidea
force-pushed
the
cli/run-etcd
branch
from
a3a64de to
1c246ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the effort on adding a powerful CLI to the operator and depends on #74.
It allows the operator to run and register its resources on etcd as it always did, but this time it can just be done as
cnwan-operator run etcd [FLAGS].TODOs:
runcommandOther todos coming.