Fix various problems in ctslab tests #3973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrwahl2
reviewed
Oct 13, 2025
| r"pacemaker-controld.*:.*not in our membership list", | ||
| r"CRIT:.*node.*returning after partition" | ||
| r"CRIT:.*node.*returning after partition", | ||
| self._cm.templates["Pat:Fencing_active"], |
There was a problem hiding this comment.
It's not clear to me how this ever worked even before the message changed, since we didn't have this pattern in errors_to_ignore()... I guess it never did work for the split brain test, and it broke with the mentioned commit for component fail and stonithd?
There was a problem hiding this comment.
Right, I don't think SplitBrainTest has worked in a long time. We just didn't know it because it never ran until 14406ce.
This should have been done along with 87a527e.
This has been broken since the message changed in 07a19bc, but we didn't notice because the SplitBrain test has been disabled for a long time. Additionally, I've removed the "stonith " part from the beginning of the string. Other resources can cause the same message to be printed in the SplitBrain test. We could have a whole separate message for this case, but I'm not sure it's worth it.
There's probably almost endless amounts of this that could be done in CTS, and I don't really want to get started on that but I was already in the area.
nrwahl2
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.