Low: daemons: Get rid of some logged warnings in execd. #3974
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle_ipc_fwd_request and handle_poke_request are pretty obvious. These two functions need to call pcmk__set_result to set the rc value into the result object or else execd will log a message about "Unknown status (bug?)". This should have been done as part of ClusterLabs#3915 which converted execd to use pcmk__request_t. The other changes in ipc_proxy_forward_client are just to enable setting the proper rc value for handle_ipc_fwd_request. handle_rsc_info_request is a little less obvious because ENODEV seems like something we should definitely be logging. However, this will be returned as part of regular processing - see the existing comment. Logging the error ENODEV message is alarming, and before execd used pcmk__request_t it wasn't treated as an error. So we'll restore that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_ipc_fwd_request and handle_poke_request are pretty obvious. These two functions need to call pcmk__set_result to set the rc value into the result object or else execd will log a message about "Unknown status (bug?)". This should have been done as part of #3915 which converted execd to use pcmk__request_t.
The other changes in ipc_proxy_forward_client are just to enable setting the proper rc value for handle_ipc_fwd_request.
handle_rsc_info_request is a little less obvious because ENODEV seems like something we should definitely be logging. However, this will be returned as part of regular processing - see the existing comment. Logging the error ENODEV message is alarming, and before execd used pcmk__request_t it wasn't treated as an error. So we'll restore that here.