Fix oem_file_classification_name field, add AsciiString and Timestamp handling #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixed length null terminated string for encoding/decoding PDRs, wrapping the underlying VecWrap bytes. Signed-off-by: Matt Johnston <[email protected]>
This adds Eq comparison and other common traits to the protocol structs. Signed-off-by: Matt Johnston <[email protected]>
The length field is now omitted entirely when oem_classification is set to 0. Previously in that case length was included and set to zero, which is not the correct message format. The name field is renamed from oem_file_name to oem_file_classification_name, and is now an Option. Signed-off-by: Matt Johnston <[email protected]>
The PLDM file host example now sets updateTime to the local time for testing purposes. Signed-off-by: Matt Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the File Descriptor response message format, as well as adding some convenience functions for displaying the filename.