mctpd: support discovery requests #16
Conversation
|
All look great, thanks. We should probably include some top-level configuration on whether mctpd is running as an endpoint vs bus owner (and/or do we need to distingush a TMBO?). Even a command-line argument would be sufficient there. For example, this would affect the Set Endpoint ID handling; in bus-owner mode, we would reject all Set Endpoint ID commands; rather than being conditional on whether an EID is already assigned. In endpoint mode, it should be totally fine for the bus owner to reassign EIDs. Is that something you'd like to do? If not, I can implement as a base change. |
|
@jk-ozlabs Sorry for the late reply. I made a MR to add the BO configuration at #14, if that is what you meant. |
Ah! Thank you. I should have started there. |
khangng-ampere
force-pushed
the
discovery-messages
branch
from
a228e9c to
36a346c
Compare
Currently, mctpd handles Set EID message as a bus owner, which means it assumes it has at least one local EID and rejects all Set Endpoint ID requests. This commit handles the case where mctpd runs on an endpoint and it has no EID set yet. Signed-off-by: Khang D Nguyen <[email protected]>
This adds support for the Discovered flag and discovery requests, as described in DSP0236 12.14 Prepare for Endpoint Discovery and 12.15 Endpoint Discovery. Signed-off-by: Khang D Nguyen <[email protected]>
khangng-ampere
force-pushed
the
discovery-messages
branch
from
36a346c to
9445cac
Compare
|
I figured it might be a good time to refresh those patches :) Added a basic test case to exercise the new path, and check for Bus Owner as discussed above. |
khangng-ampere
changed the title
|
How does this relate to #16? should I check that one out first, or this one? |
@jk-ozlabs Do you mean #96 (set endpoint ID)? This one is based on top of Set Endpoint ID so you should review that one first. Discovery process contains setting EID, so I think basing this on Set Endpoint ID makes more sense. Set Endpoint ID also works standalone, and not every transport requires discovery |
|
Sorry, yes, #96. OK, will start there. |
This PR adds support for replying to discovery messages, when
mctpdruns on an endpoint: