Skip to content

London | ITP May 25 | Lahlah Houssam | Sprint 2 | Coursework #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

London | ITP May 25 | Lahlah Houssam | Sprint 2 | Coursework #698

wants to merge 27 commits into from

Conversation

@HoussamLh
Copy link

@HoussamLh HoussamLh commented Sep 7, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This pull request for syn my fork and updating my branch.

Questions

Please, Let me know if there is anything else went wrong?

HoussamLh and others added 27 commits June 17, 2025 23:30
@HoussamLh
explain Increment count variable by 1 after initialization.
2dd0a78
@HoussamLh
Create initials variable by extracting first characters of first, mid…
1bc5c74 
…dle, and last names.
@HoussamLh
create two variable and Extract directory and file extension parts fr…
b16d048 
…om file path string using slice.
@HoussamLh
Add comments explaining how num is calculated as a random integer bet…
625c114 
…ween minimum and maximum.
@HoussamLh
Add explanation for incrementing count variable by 1 after initializa…
f5522e7 
…tion.
@HoussamLh
I believe that I've Done the sprint 1 and this the last exercise.
1cf3f70
@HoussamLh
I believe that I've completed the first sprint.
b76c5a3
@HoussamLh
I've changed const to let for age variable to allow reassignment
0748f7c
@HoussamLh
Avoid redeclaring 'str' inside capitalise function
d957dd1
@HoussamLh
Remove redeclaration of parameter and undefined variable usage in con…
fcba7aa 
…vertToPercentage
@HoussamLh
Use valid parameter name instead of number in square function
c278bbb
@HoussamLh
Avoid redeclaring 'str' inside capitalise function
335cc37
@HoussamLh
Return value from multiply function instead of just logging it
2f9d4da
@HoussamLh
Correct return statement in sum function to return a + b
bdc5ac9
@HoussamLh
Update getLastDigit function to use input parameter instead of consta…
16d6577 
…nt value
@HoussamLh
Implement calculateBMI function with 1 decimal rounding
8796b5b
@HoussamLh
Convert strings to UPPER_SNAKE_CASE format
1b5f2cf
@HoussamLh
Create reusable toPounds function with test cases
6573f60
@HoussamLh
Add inline comments explaining pad and formatTimeDisplay behaviour
01a1ced
@HoussamLh
Correct 12-hour clock formatting and add comprehensive tests
eeff899
@HoussamLh
Revert Sprint-1 folder to CYF's original version
f39781a
@HoussamLh
Revert Sprint-1 folder to CYF's original version
bce599b
@HoussamLh
convert kg to pounds and round to 2 decimal places
19f296f
@HoussamLh
Create reusable toPounds function from Sprint-1 code
f63026f
@HoussamLh
format 12-hour time consistently with 2-digit hours
a9c2a21
@HoussamLh
Refactor formatAs12HourClock to reduce code duplication
5eb1ab8 
Moved padStart(2, "0") to a single location after calculating rawHour.
Improves readability and makes the function easier to maintain.
Thanks for the helpful suggestion!
@HoussamLh
Merge branch 'CodeYourFuture:main' into acoursework/sprint-2
c229426
@HoussamLh HoussamLh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 7, 2025
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@cjyuan
Copy link
Contributor

cjyuan commented Sep 7, 2025

I had reviewed and mark your work as "Complete" in the previous cohort.

There seems to be an issue in your PR title. Can you address this issue so that I can mark this PR as complete?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 7, 2025
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh changed the title London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Acoursework/sprint 2 London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Acoursework/sprint 2 Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh changed the title London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Acoursework/sprint 2 London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Acoursework/sprint-2 Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh changed the title London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Acoursework/sprint-2 London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Coursework/sprint-2 Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh changed the title London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Coursework/sprint-2 London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Coursework Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh changed the title London | 25-ITP-May | Houssam Lahlah | Sprint-2 | Coursework London | Cohort 2 | Lahlah Houssam | Sprint 2 | Coursework Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh changed the title London | Cohort 2 | Lahlah Houssam | Sprint 2 | Coursework London | ITP May 25 | Lahlah Houssam | Sprint 2 | Coursework Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HoussamLh HoussamLh closed this Sep 9, 2025
@HoussamLh HoussamLh deleted the acoursework/sprint-2 branch September 9, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HoussamLh @cjyuan