Manchester | ITP-Sept-2025 | Fithi Teklom| Sprint 3 | Coursework/sprint-3-implement-and-rewrite #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fithi-Teklom
added
the
Needs Review
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
Fithi-Teklom
changed the title
CameronDowner
left a comment
CameronDowner
left a comment
There was a problem hiding this comment.
This is looking really good!
I've added a couple stretch comments / questions, but overall a really great submission
Comment on lines
11
to
15
| if (numerator < denominator) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
tip: if numerator < denominator evaluates to true/false, do we need a if statement here?
|
|
||
| // Case 2: Identify Improper Fractions: | ||
| test("should return false for an improper fraction (numerator > denominator)", () => { | ||
| expect(isProperFraction(5, 2)).toEqual(false); |
There was a problem hiding this comment.
question: why would we use .toEqual(false) instead of .toBeFalsy()?
toEqual(false)
| }); | ||
| // Case 5: Handle Invalid Cards: | ||
| test("should throw an error for invalid card rank", () => { | ||
| expect(() => getCardValue("Z♠")).toThrow("Invalid card rank"); |
There was a problem hiding this comment.
question: why do we use an arrow function here?
CameronDowner
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist