Remove Reflection*::setAccessible() calls #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

W0rma wants to merge 1 commit into Codeception:main from W0rma:reflection-set-accessible

Contributor

W0rma commented Jul 31, 2025

As of PHP 8.1.0, calling this method has no effect; all methods are invokable by default.

(https://www.php.net/manual/en/reflectionmethod.setaccessible.php and https://www.php.net/manual/en/reflectionproperty.setaccessible.php).

There're even plans to deprecate the method in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations

This package requires at least PHP 8.1.
Thus, the calls can be safely removed.


          setAccessible() has no effect as of PHP 8.1

01c5cec

Contributor Author

W0rma commented Aug 2, 2025

CI failure are unrelated.

I'm confused because the CI is green in my fork: https://github.com/W0rma/module-doctrine/actions/runs/16645690847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet