Skip to content

fix: fixes #131 yiilogger may not be initialized in _failed #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025
Merged

fix: fixes #131 yiilogger may not be initialized in _failed #132

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b480bf1
fix: fixes #131 yiilogger may not be initialized in _failed
SamMousa May 29, 2025
9e0ea24
chore: make logger explicitly nullable
SamMousa May 30, 2025
f3ce1ca
chore: fixed SA errors due to phpstan update
SamMousa May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Codeception/Module/Yii2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@
*/
public function _failed(TestInterface $test, $fail): void
{
$log = $this->yiiLogger->getAndClearLog();
if ($log !== '') {
$log = $this->yiiLogger?->getAndClearLog();

Check failure on line 463 in src/Codeception/Module/Yii2.php

View workflow job for this annotation

GitHub Actions / tests (8.4) 

Using nullsafe method call on non-nullable type Codeception\Lib\Connector\Yii2\Logger. Use -> instead.

Check failure on line 463 in src/Codeception/Module/Yii2.php

View workflow job for this annotation

GitHub Actions / tests (8.3) 

Using nullsafe method call on non-nullable type Codeception\Lib\Connector\Yii2\Logger. Use -> instead.
if (isset($log) && $log !== '') {

Check failure on line 464 in src/Codeception/Module/Yii2.php

View workflow job for this annotation

GitHub Actions / tests (8.4) 

Variable $log in isset() always exists and is not nullable.

Check failure on line 464 in src/Codeception/Module/Yii2.php

View workflow job for this annotation

GitHub Actions / tests (8.3) 

Variable $log in isset() always exists and is not nullable.
$test->getMetadata()->addReport('yii-log', $log);
}

Expand Down
Loading