Skip to content

Conversation

@girishpanchal30
Copy link
Contributor

Summary

Update JS dependency from accounting to wc-accounting for compatibility with WooCommerce 10.3.0.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/597

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 27, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 27, 2025
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 27, 2025

Plugin build for b35c948 is ready 🛎️!

@vytisbulkevicius
Copy link
Contributor

@Soare-Robert-Daniel should we just close this PR because of the change from woocommerce that fixed it? https://github.com/Codeinwp/ppom-pro/issues/597#issuecomment-3450061169

Or is there still any reason having it? Thanks

@Soare-Robert-Daniel
Copy link
Contributor

Or is there still any reason having it? Thanks

I think yes. They did that because it was breaking the sites for too many people, but we should move forward with the integration that they are going to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants