Major CodeQA - 20250119

CollapseLauncher/App.xaml

@@ -3,7 +3,6 @@
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              xmlns:animatedvisuals="using:Microsoft.UI.Xaml.Controls.AnimatedVisuals"
              xmlns:conv="using:CollapseLauncher.Pages"
-             xmlns:interactions="using:Microsoft.Xaml.Interactions.Core"
              xmlns:interactivity="using:Microsoft.Xaml.Interactivity"
              xmlns:controls="using:Microsoft.UI.Xaml.Controls"
              xmlns:primitives="using:Microsoft.UI.Xaml.Controls.Primitives"
@@ -2190,13 +2189,13 @@
                                             <!--  Force ShouldConstrainToRootBounds to True  -->
                                             <!--  Fix https://github.com/microsoft/microsoft-ui-xaml/issues/8657  -->
                                             <interactivity:Interaction.Behaviors>
-                                                <interactions:DataTriggerBehavior Binding="{Binding ShouldConstrainToRootBounds, ElementName=Popup}"
+                                                <interactivity:DataTriggerBehavior Binding="{Binding ShouldConstrainToRootBounds, ElementName=Popup}"
                                                                                   ComparisonCondition="Equal"
                                                                                   Value="False">
-                                                    <interactions:ChangePropertyAction PropertyName="ShouldConstrainToRootBounds"
+                                                    <interactivity:ChangePropertyAction PropertyName="ShouldConstrainToRootBounds"
                                                                                        TargetObject="{Binding ElementName=Popup}"
                                                                                        Value="True" />
-                                                </interactions:DataTriggerBehavior>
+                                                </interactivity:DataTriggerBehavior>
                                             </interactivity:Interaction.Behaviors>
                                             <Border x:Name="PopupBorder"
                                                     Margin="0,-0.5,0,-1"
@@ -2627,13 +2626,13 @@
                                             <!--  Force ShouldConstrainToRootBounds to True  -->
                                             <!--  Fix https://github.com/microsoft/microsoft-ui-xaml/issues/8657  -->
                                             <interactivity:Interaction.Behaviors>
-                                                <interactions:DataTriggerBehavior Binding="{Binding ShouldConstrainToRootBounds, ElementName=Popup}"
+                                                <interactivity:DataTriggerBehavior Binding="{Binding ShouldConstrainToRootBounds, ElementName=Popup}"
                                                                                   ComparisonCondition="Equal"
                                                                                   Value="False">
-                                                    <interactions:ChangePropertyAction PropertyName="ShouldConstrainToRootBounds"
+                                                    <interactivity:ChangePropertyAction PropertyName="ShouldConstrainToRootBounds"
                                                                                        TargetObject="{Binding ElementName=Popup}"
                                                                                        Value="True" />
-                                                </interactions:DataTriggerBehavior>
+                                                </interactivity:DataTriggerBehavior>
                                             </interactivity:Interaction.Behaviors>
                                             <Border x:Name="PopupBorder"
                                                     Margin="0,-0.5,0,-1"

CollapseLauncher/App.xaml.cs

@@ -14,20 +14,23 @@
 using Windows.UI;
 using static CollapseLauncher.InnerLauncherConfig;
 using static Hi3Helper.Logger;
+// ReSharper disable SwitchStatementMissingSomeEnumCasesNoDefault
+// ReSharper disable CommentTypo
+// ReSharper disable StringLiteralTypo
 
 namespace CollapseLauncher
 {
     public partial class App
     {
-        public static bool IsAppKilled = false;
+        public static bool IsAppKilled { get; set; } = false;
 
         public App()
         {
             if (DebugSettings != null)
             {
-#if ENABLEFRAMECOUNTER
+            #if ENABLEFRAMECOUNTER
                 DebugSettings.EnableFrameRateCounter = true;
-#endif
+            #endif
 #if DEBUG
                 DebugSettings.LayoutCycleDebugBreakLevel = LayoutCycleDebugBreakLevel.High;
                 DebugSettings.LayoutCycleTracingLevel = LayoutCycleTracingLevel.High;
@@ -68,7 +71,7 @@ public App()
             RequestedTheme = IsAppThemeLight ? ApplicationTheme.Light : ApplicationTheme.Dark;
             PInvoke.SetPreferredAppMode(PInvoke.ShouldAppsUseDarkMode() ? PreferredAppMode.AllowDark : PreferredAppMode.Default);
 
-            this.InitializeComponent();
+            InitializeComponent();
         }
 
         protected override void OnLaunched(LaunchActivatedEventArgs args)

CollapseLauncher/Classes/CachesManagement/Honkai/Check.cs

@@ -10,6 +10,7 @@
 using System.Threading.Tasks;
 using static Hi3Helper.Locale;
 using static Hi3Helper.Logger;
+// ReSharper disable CommentTypo
 
 namespace CollapseLauncher
 {
@@ -18,20 +19,20 @@ internal partial class HonkaiCache
         private async Task<List<CacheAsset>> Check(List<CacheAsset> assetIndex, CancellationToken token)
         {
             // Initialize asset index for the return
-            List<CacheAsset> returnAsset = new List<CacheAsset>();
+            List<CacheAsset> returnAsset = [];
 
             // Set Indetermined status as false
-            _status.IsProgressAllIndetermined = false;
+            Status.IsProgressAllIndetermined = false;
 
             // Show the asset entry panel
-            _status.IsAssetEntryPanelShow = true;
+            Status.IsAssetEntryPanelShow = true;
 
             try
             {
                 // Create the cache directory if it doesn't exist
-                if (!Directory.Exists(_gamePath))
+                if (!Directory.Exists(GamePath))
                 {
-                    Directory.CreateDirectory(_gamePath!);
+                    Directory.CreateDirectory(GamePath!);
                 }
 
                 // Check for unused files
@@ -40,7 +41,7 @@ private async Task<List<CacheAsset>> Check(List<CacheAsset> assetIndex, Cancella
                 // Do check in parallelization.
                 await Parallel.ForEachAsync(assetIndex!, new ParallelOptions
                 {
-                    MaxDegreeOfParallelism = _threadCount,
+                    MaxDegreeOfParallelism = ThreadCount,
                     CancellationToken = token
                 }, async (asset, localToken) =>
                 {
@@ -59,7 +60,7 @@ private async Task<List<CacheAsset>> Check(List<CacheAsset> assetIndex, Cancella
         private void CheckUnusedAssets(List<CacheAsset> assetIndex, List<CacheAsset> returnAsset)
         {
             // Directory info and if the directory doesn't exist, return
-            DirectoryInfo directoryInfo = new DirectoryInfo(_gamePath);
+            DirectoryInfo directoryInfo = new DirectoryInfo(GamePath);
             if (!directoryInfo.Exists)
             {
                 return;
@@ -71,52 +72,54 @@ private void CheckUnusedAssets(List<CacheAsset> assetIndex, List<CacheAsset> ret
             {
                 string filePath = fileInfo.FullName;
 
-                if (!filePath.Contains("output_log", StringComparison.OrdinalIgnoreCase)
-                 && !filePath.Contains("Crashes", StringComparison.OrdinalIgnoreCase)
-                 && !filePath.Contains("Verify.txt", StringComparison.OrdinalIgnoreCase)
-                 && !filePath.Contains("APM", StringComparison.OrdinalIgnoreCase)
-                 && !filePath.Contains("FBData", StringComparison.OrdinalIgnoreCase)
-                 && !filePath.Contains("asb.dat", StringComparison.OrdinalIgnoreCase)
-                 && !assetIndex.Exists(x => x.ConcatPath == fileInfo.FullName))
+                if (filePath.Contains("output_log",    StringComparison.OrdinalIgnoreCase)
+                    || filePath.Contains("Crashes",    StringComparison.OrdinalIgnoreCase)
+                    || filePath.Contains("Verify.txt", StringComparison.OrdinalIgnoreCase)
+                    || filePath.Contains("APM",        StringComparison.OrdinalIgnoreCase)
+                    || filePath.Contains("FBData",     StringComparison.OrdinalIgnoreCase)
+                    || filePath.Contains("asb.dat",    StringComparison.OrdinalIgnoreCase)
+                    || assetIndex.Exists(x => x.ConcatPath == fileInfo.FullName))
                 {
-                    // Increment the total found count
-                    _progressAllCountFound++;
-
-                    // Add asset to the returnAsset
-                    CacheAsset asset = new CacheAsset()
-                    {
-                        BasePath = Path.GetDirectoryName(filePath),
-                        N = Path.GetFileName(filePath),
-                        DataType = CacheAssetType.Unused,
-                        CS = fileInfo.Length,
-                        CRC = null,
-                        Status = CacheAssetStatus.Unused,
-                        IsUseLocalPath = true
-                    };
-                    returnAsset!.Add(asset);
-
-                    // Add to asset entry display
-                    Dispatch(() => AssetEntry!.Add(new AssetProperty<CacheAssetType>(
-                            asset.N,
-                            asset.DataType,
-                            asset.BasePath,
-                            asset.CS,
-                            null,
-                            null
-                        ))
-                    );
-
-                    LogWriteLine($"File: {asset.ConcatPath} is unused!", LogType.Warning, true);
+                    continue;
                 }
+
+                // Increment the total found count
+                ProgressAllCountFound++;
+
+                // Add asset to the returnAsset
+                CacheAsset asset = new CacheAsset
+                {
+                    BasePath       = Path.GetDirectoryName(filePath),
+                    N              = Path.GetFileName(filePath),
+                    DataType       = CacheAssetType.Unused,
+                    CS             = fileInfo.Length,
+                    CRC            = null,
+                    Status         = CacheAssetStatus.Unused,
+                    IsUseLocalPath = true
+                };
+                returnAsset!.Add(asset);
+
+                // Add to asset entry display
+                Dispatch(() => AssetEntry!.Add(new AssetProperty<CacheAssetType>(
+                                                    asset.N,
+                                                    asset.DataType,
+                                                    asset.BasePath,
+                                                    asset.CS,
+                                                    null,
+                                                    null
+                                                   ))
+                        );
+
+                LogWriteLine($"File: {asset.ConcatPath} is unused!", LogType.Warning, true);
             }
         }
 
         private async ValueTask CheckAsset(CacheAsset asset, List<CacheAsset> returnAsset, CancellationToken token)
         {
             // Increment the count and update the status
-            Interlocked.Add(ref _progressAllCountCurrent, 1);
-            _status.ActivityStatus = string.Format(Lang!._CachesPage!.CachesStatusChecking!, asset!.DataType, asset.N);
-            _status.ActivityAll = string.Format(Lang._CachesPage.CachesTotalStatusChecking!, _progressAllCountCurrent, _progressAllCountTotal);
+            Interlocked.Add(ref ProgressAllCountCurrent, 1);
+            Status.ActivityStatus = string.Format(Lang!._CachesPage!.CachesStatusChecking!, asset!.DataType, asset.N);
+            Status.ActivityAll = string.Format(Lang._CachesPage.CachesTotalStatusChecking!, ProgressAllCountCurrent, ProgressAllCountTotal);
 
             // Assign the file info.
             FileInfo fileInfo = new FileInfo(asset.ConcatPath).EnsureNoReadOnly(out bool isExist);
@@ -136,15 +139,15 @@ private async ValueTask CheckAsset(CacheAsset asset, List<CacheAsset> returnAsse
             }
 
             // Skip CRC check if fast method is used
-            if (_useFastMethod)
+            if (UseFastMethod)
             {
                 return;
             }
 
             // If above passes, then run the CRC check
             await using FileStream fs = await NaivelyOpenFileStreamAsync(fileInfo, FileMode.Open, FileAccess.Read, FileShare.Read);
             // Calculate the asset CRC (SHA1)
-            byte[] hashArray = await GetCryptoHashAsync<HMACSHA1>(fs, _gameSalt, true, true, token);
+            byte[] hashArray = await GetCryptoHashAsync<HMACSHA1>(fs, GameSalt, true, true, token);
 
             // If the asset CRC doesn't match, then add the file to asset index.
             if (!IsArrayMatch(asset.CRCArray, hashArray))
@@ -159,9 +162,9 @@ private void AddGenericCheckAsset(CacheAsset asset, CacheAssetStatus assetStatus
             lock (this)
             {
                 // Set Indetermined status as false
-                _status.IsProgressAllIndetermined = false;
-                _progressAllCountFound++;
-                _progressAllSizeFound += asset!.CS;
+                Status.IsProgressAllIndetermined = false;
+                ProgressAllCountFound++;
+                ProgressAllSizeFound += asset!.CS;
             }
 
             // Add file into asset index