feat: lifestyle tabs ui match#95
Conversation
|
Warning Review limit reached
More reviews will be available in 45 minutes and 6 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds localized lifestyle tab labels in four languages and changes the LifeStyle page to switch between diet and physio/training content with a tab control. ChangesLifestyle tab navigation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| import * as styles from './styles' | ||
|
|
||
| const TAB_DIET = 'diet' | ||
| const TAB_PHYSIO = 'physio' |
There was a problem hiding this comment.
I would save those inside constant file
| <RecomendationTraining /> | ||
| <DietTabExample /> | ||
| </> | ||
| <Box sx={styles.containerStyle}> |
There was a problem hiding this comment.
why do you need box from mui and not regular div? or even use the existing container component:
src/components/UI/Container/SGLContainer.tsx
| <Box sx={styles.switchWrapperStyle}> | ||
| <SGLSwitch options={options} value={activeTab} onChange={setActiveTab} /> | ||
| </Box> | ||
| {activeTab === TAB_DIET && <DietTabExample />} |
There was a problem hiding this comment.
There are only 2 tabs, so you can do {activeTab === TAB_DIET ? : }
| @@ -0,0 +1,12 @@ | |||
| export const containerStyle = { | |||
| display: 'flex', | |||
| flexDirection: 'column' as const, | |||
There was a problem hiding this comment.
Why do you need as const in here? you can make this object satisfy CSSProperties instead
pnpm dev pnpm dev '
GilHeller
left a comment
There was a problem hiding this comment.
LGTM, but you have a conflict. Please fix it
|
Fixed!נשלח מה-iPhone שליב-25 ביוני 2026, בשעה 21:32, GilHeller ***@***.***> כתב/ה:
@GilHeller commented on this pull request.
LGTM, but you have a conflict. Please fix it
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Description
Match Lifestyle page UI to design mockups.
Changes:
Related Issue(s)
Fixes # (issue number)
Checklist:
Screenshots (if appropriate):
Summary by CodeRabbit