Skip to content

Fix for MariaDB re Issue #119 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for MariaDB re Issue #119 #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66be88b
implemented fix from https://github.com/ColorlibHQ/simple-custom-post…
cogdesign14 Feb 3, 2025
bb58cbe
implemented fix from https://github.com/ColorlibHQ/simple-custom-post…
cogdesign14 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 37 additions & 13 deletions simple-custom-post-order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Plugin Name: Simple Custom Post Order
* Plugin URI: https://wordpress.org/plugins-wp/simple-custom-post-order/
* Description: Order Items (Posts, Pages, and Custom Post Types) using a Drag and Drop Sortable JavaScript.
* Version: 2.5.10
* Version: 2.5.11
* Author: Colorlib
* Author URI: https://colorlib.com/
* Tested up to: 6.7
Expand Down Expand Up @@ -272,18 +272,42 @@ public function refresh() {
}

// Here's the optimization
$wpdb->query( 'SET @row_number = 0;' );
$wpdb->query(
"UPDATE $wpdb->posts as pt JOIN (

SELECT ID, (@row_number:=@row_number + 1) AS `rank`
FROM $wpdb->posts
WHERE post_type = '$object' AND post_status IN ( 'publish', 'pending', 'draft', 'private', 'future' )
ORDER BY menu_order ASC
) as pt2
ON pt.id = pt2.id
SET pt.menu_order = pt2.`rank`;"
);
// $wpdb->query( 'SET @row_number = 0;' );
// $wpdb->query(
// "UPDATE $wpdb->posts as pt JOIN (

// SELECT ID, (@row_number:=@row_number + 1) AS `rank`
// FROM $wpdb->posts
// WHERE post_type = '$object' AND post_status IN ( 'publish', 'pending', 'draft', 'private', 'future' )
// ORDER BY menu_order ASC
// ) as pt2
// ON pt.id = pt2.id
// SET pt.menu_order = pt2.`rank`;"
// );

//fix from https://github.com/ColorlibHQ/simple-custom-post-order/issues/119
$current_orders = $wpdb->get_results(
$wpdb->prepare( "SELECT ID, menu_order FROM {$wpdb->posts} WHERE post_type = %s AND post_status IN ('publish', 'pending', 'draft', 'private', 'future') ORDER BY menu_order ASC", $object )
);

$subquery = "";

foreach ( $current_orders as $key => $current_order ) {
if( ! $key ){
$subquery .= $wpdb->prepare( "SELECT %s ID, %d `rank`", $current_order->ID, $key + 1 );
}else{
$subquery .= $wpdb->prepare( " UNION ALL SELECT %s, %d", $current_order->ID, $key + 1 );
}
}

$wpdb->query( 'SET @row_number = 0;' );
$wpdb->query(
"UPDATE $wpdb->posts as pt JOIN (
$subquery
) as pt2
ON pt.id = pt2.id
SET pt.menu_order = pt2.`rank`;"
);

}
}
Expand Down