Prevent building fragments from hitting their source - #4661
Draft
WhiteGiverMa wants to merge 1 commit into
Draft
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-29182189983.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
Changes
References
Tried to destroy already-destroyed thing Turret_AutoChargeBlaster...Reasoning
Harmony_DamageWorker_Applyemits building fragments before the original damage worker runs.CompFragments.FragRoutineticks each emitted fragment immediately. A fragment can collide with the building that emitted it, destroy it, and return to the outer damage worker.Kill()for the same, already-destroyed building and emits a false duplicate-destroy error.Alternatives
Testing
dotnet build Source\CombatExtended\CombatExtended.csproj -c Release --no-restoredotnet test Source\Tests\Tests.csproj -c Release --no-restore(1 passed)