fix: correct exit codes and error messages across CLI commands#388
Merged
fix: correct exit codes and error messages across CLI commands#388
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 70.94% 71.07% +0.12%
==========================================
Files 33 33
Lines 3931 3931
==========================================
+ Hits 2789 2794 +5
+ Misses 1142 1137 -5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
launch_comfyuibackground mode,os._exit(process.pid)was passing the process PID (e.g. 12345) as the exit code instead of the actual return code. The foreground mode had a similar issue on one path whereexit(res)passed the entireCompletedProcessobject instead ofres.returncode.The
install,reinstall, anduninstallcommands printed"Invalid command: {mode}"when rejectingallas an argument, butmodeis the unrelated--modeoption (remote/local/cache) which defaults toNone, so users saw"Invalid command: None.".Also fixes a stray
)in the GitHub rate limit error message and a "migit" typo.