Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 71.07% 70.98% -0.10%
==========================================
Files 33 33
Lines 3931 3915 -16
==========================================
- Hits 2794 2779 -15
+ Misses 1137 1136 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The torch installation in
pip_install_comfyui_dependenciesrepeated the samesubprocess.run([python, "-m", "pip", "install", "torch", "torchvision", "torchaudio"] + index_args)pattern four times for AMD Linux, NVIDIA, Intel Arc, and CPU backends. Extracted a_pip_install_torchhelper that all four call. DirectML and Mac M Series have different command shapes so they stay inline.parse_pr_referenceandparse_frontend_pr_referencewere copy-pasted functions that only differed in the default repo (comfyanonymous/ComfyUIvsComfy-Org/ComfyUI_frontend). Unified them into a shared_parse_pr_reference(pr_ref, default_owner, default_repo)with thin public wrappers. Also hardcoded the upstream repo inhandle_temporary_frontend_pr'sfind_pr_by_branchcall to match howhandle_pr_checkoutalready works.