handling empty spectra #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di-hardt
force-pushed
the
fix-handling-empty-spectra
branch
from
1369649 to
ce1f8b2
Compare
RalfG
added a commit
that referenced
this pull request
Sep 29, 2025
RalfG
added a commit
that referenced
this pull request
Sep 29, 2025
* update version and mzdata version * add clippy to github workflow * proposed fixes clippy * import Path * Upgrade to mzdata 0.59.2 * Undo adding cache action, as clippy is run only once * Undo map_err changes to avoid merge conflicts with #5 --------- Co-authored-by: RalfG <[email protected]>
RalfG
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Sage this fix implements skipping of decompression errors, which indicates an empty spectrum (development branch of timsrust already has a new error type for this). Unlike Sage's implementation, other errors are still returned.
With this fix MS runs like https://ftp.pride.ebi.ac.uk/pride/data/archive/2022/02/PXD028735/LFQ_timsTOFPro_PASEF_Human_01.d.zip can be processed using MS2Rescore.
Fixed
Changed
std::io::Error::other.