Skip to content

Conversation

@julianu
Copy link
Contributor

@julianu julianu commented May 2, 2025

Changed

  • io.pepxml: Refactor spectrum naming logic to prefer 'spectrumNativeID' when available

A fix to fetch all scores from a pepXML and use the "spectrumNativeID" for preferred spectrum naming.

@RalfG
Copy link
Member

RalfG commented Oct 27, 2025

Thanks, @julianu! Would you say that most of these metadata values could serve as rescoring features? If so, we could put them in that PSM dictionary instead. What do you think?

@julianu
Copy link
Contributor Author

julianu commented Oct 27, 2025

Hej Ralf,
Yes, I think they can also be used for the rescoring (I am actually using them in my branch).
But if I remember correctly, these scores were also just not imported before this fix (sorry, don't remember 100% as it is already some time ago now).

@RalfG
Copy link
Member

RalfG commented Oct 27, 2025

Ah, sorry. I misread the diff and thought that they were newly parsed from the file. Thanks for catching the bug!

@RalfG RalfG merged commit 4f15e3a into CompOmics:main Oct 27, 2025
5 checks passed
@RalfG RalfG added this to the v1.5.0 milestone Oct 27, 2025
@RalfG RalfG added the enhancement Improvement of an existing feature label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of an existing feature

Development

Successfully merging this pull request may close these issues.

2 participants