fix(python): handle missing JSON schema titles in json_schema_to_model#2705
Open
liuxiaopai-ai wants to merge 2 commits intoComposioHQ:nextfrom
Open
fix(python): handle missing JSON schema titles in json_schema_to_model#2705liuxiaopai-ai wants to merge 2 commits intoComposioHQ:nextfrom
liuxiaopai-ai wants to merge 2 commits intoComposioHQ:nextfrom
Conversation
Fixes ComposioHQ#2435 - Provide a fallback model name when schema omits title/name - Add regression test for anonymous nested object schemas
|
Someone is attempting to deploy a commit to the Composio Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
FYI: the failing 'Vercel' check appears to be an integration/auth issue on the repo side ('Authorization required to deploy'), not related to this Python-only change. If needed, a maintainer may need to authorize Vercel for this PR/run or mark it non-blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2435
Problem
The Python helper
json_schema_to_modelcould pass a null/None model name intopydantic.create_modelwhen the JSON schema omittedtitle(common for anonymous nested object schemas, e.g. array items). This raises:Fix
nameand finally a generated model name whentitleis missingValidation
pytest -q python/tests/test_json_schema_to_model_missing_title.pyruff check python/composio/utils/shared.py python/tests/test_json_schema_to_model_missing_title.py