fix(cli): fallback upgrade release selection to built assets#2797
Open
fix(cli): fallback upgrade release selection to built assets#2797
Conversation
Handle cases where the newest @composio/cli release tag exists before CI has uploaded platform binaries by selecting the latest release that includes required assets for the current platform. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The Please review and fix the vulnerabilities. You can try running: pnpm audit --fix --prodAudit output |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Replace O(n²) selection sort with O(n) linear scan in fetchLatestReleaseWithRequiredAssets; tracks the best candidate with the required platform asset in a single pass - Remove unreachable onNone branch from fetchLatestRelease; function is only ever called from the onSome branch of githubConfig.TAG Option.match, so the dead code is eliminated and tag is now passed as a parameter instead of re-read from config - Expand upgrade-binary test suite from 3 to 21 tests with synthetic GitHub API response fixtures covering: release filtering (prerelease, draft, non-CLI packages), platform binary selection, O(n) scan correctness, version comparison, tagged release fetching, runtime path detection, and download error handling Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| } | ||
|
|
||
| yield* Effect.logDebug( | ||
| `Resolved latest CLI release with required assets: ${release.tag_name}` |
There was a problem hiding this comment.
Duplicated binary name construction not using new helper
Low Severity
The new getBinaryAssetName helper constructs the binary name string, but downloadBinary still builds the identical string inline at line 230. If the naming convention ever changes, one site could be updated while the other is missed, causing a silent mismatch between the asset-filtering logic and the download logic.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composio upgradeselect the newest@composio/clirelease that includes the required platform binary assetTest plan
pnpm --filter @composio/cli typecheckcomposio upgradeagainst a release stream where newest tag is missing assets and verify it upgrades to the previous valid releasecomposio upgradewhen already on latest valid release and verify it reports no upgrade neededMade with Cursor