TheGreatCleanup #52
Merged
TheGreatCleanup #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We also have around 1k warnings because of not specifying type annotations for public variables and functions, personally for now I just silenced them but I can add those type annotations if you want |
szymon-rd
reviewed
Jun 19, 2025
| def of[T <: Value: Tag: FromExpr](xs: List[T]) = | ||
| GSeq | ||
| .gen[Int32](0, _ + 1) | ||
| .map { i => |
| when(n1 > n2) { | ||
| val n = n1 / n2 | ||
| val sinT2 = n * n * (1f - cosX * cosX) | ||
| when(sinT2 > 1f) { |
Member
There was a problem hiding this comment.
here and everywhere else we can also get rid of {
szymon-rd
reviewed
Jun 19, 2025
| */ | ||
| private[cyfra] abstract class CommandPool(device: Device, queue: Queue) extends VulkanObjectHandle { | ||
| private[cyfra] abstract class CommandPool(device: Device, queue: Queue) extends VulkanObjectHandle: | ||
| protected val handle: Long = pushStack { stack => |
szymon-rd
approved these changes
Jun 19, 2025
MarconZet
pushed a commit
that referenced
this pull request
Oct 20, 2025
* Added "-feature", "-deprecation", "-unchecked", "-language:implicitConversions" to scalacOptions
Whole code base should now use Scala3 new syntax and significant indents. If anyone sees unnecessary {} that I missed, please get rid of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.